@javache has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@mateoguzmana not sure if this is actually a valid use case:
https://github.com/2lambda123/BlackBerry-Dynamics-React-Native-SDK/blob/f24b0e72cfef18fa33e971667459b5af12e3d090/modules/BlackBerry-Dynamics-for-React-Native-Networking/android/src/main/java/com/blackberry/bbd/reactnative/networking/RNReactNativeBbdNetworkingModule.java#L48

Anyway I think we should mark this as breaking in the changelog

@javache merged this pull request in 360cbf7.

This pull request was successfully merged by @mateoguzmana in 360cbf7

^{When will my fix make it into a release? | How to file a pick request?}

@mateoguzmana not sure if this is actually a valid use case: https://github.com/2lambda123/BlackBerry-Dynamics-React-Native-SDK/blob/f24b0e72cfef18fa33e971667459b5af12e3d090/modules/BlackBerry-Dynamics-for-React-Native-Networking/android/src/main/java/com/blackberry/bbd/reactnative/networking/RNReactNativeBbdNetworkingModule.java#L48

Anyway I think we should mark this as breaking in the changelog

@cortinico hmm, good point, that's an interesting one. I didn't see much usage/recent activity on the repository so didn't consider it very relevant – but still maybe I could create an issue on their side to let them be aware of this breaking change. Wdyt? Curious to see how some similar cases have been handled so I can follow up as well on that

but still maybe I could create an issue on their side to let them be aware of this breaking change. Wdyt?

I think in this particular case we can create an issue on their end, saying that this function is going away. Either use an alternative or fork the code.

I was exploring using shepherd for similar scenarios in the future: https://github.com/NerdWalletOSS/shepherd